New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bit: init at 0.5.11 #100340
bit: init at 0.5.11 #100340
Conversation
sha256 = "1rdi6wsr5w64gvqkdysxrxfjxi3xbwigy3sk8wsx9zp4fql9xnw1"; | ||
}; | ||
|
||
subPackages = [ "." ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not, pulled from another example, squashes a branch testing bug.
|
||
vendorSha256 = "16c1mcvz3z17pixp904hazivx2n7y592nlx3ndnyajk7ljmnwfzy"; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be wrapped with git
in $PATH
, per: https://github.com/chriswalz/bit#using-go-harder-way-to-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding to buildInputs should suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. that won't affect it at all. Use something like this:
nixpkgs/pkgs/tools/security/gopass/default.nix
Lines 49 to 55 in 62e6142
postFixup = '' | |
for bin in $out/bin/*; do | |
wrapProgram $bin \ | |
--prefix PATH : "${wrapperPath}" | |
done | |
''; | |
@rople380 please address the reviewer comments. |
I marked this as stale due to inactivity. → More info |
Closing as OP doesn't respond. |
Motivation for this change
bit: init at 0.5.11
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)