Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.spyder_3: remove broken gui app #100366

Closed
wants to merge 1 commit into from
Closed

python3Packages.spyder_3: remove broken gui app #100366

wants to merge 1 commit into from

Conversation

marcus7070
Copy link
Member

@marcus7070 marcus7070 commented Oct 12, 2020 •
edited

@FRidh, this continues from #100126.

Motivation for this change

A recent update to Qt broke the gui app. This library is only used for
cq-editor and still works fine for that purpose, so this patch just
trims the gui app stuff out of setup.py.

I've also added some pythonImportsChecks, they are the exact modules that cq-editor needs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Result of nixpkgs-review 1
3 packages built:
  • cq-editor
  • python37Packages.spyder_3
  • python38Packages.spyder_3

@marcus7070
python3Packages.spyder_3: remove broken gui app
348b0f6 
A recent update to Qt broke the gui app. This library is only used for
cq-editor and still works fine for that purpose, so this patch just
trims the gui app stuff out of setup.py.
@ofborg ofborg bot requested a review from gebner October 12, 2020 23:04
@tfmoraes tfmoraes mentioned this pull request Dec 15, 2020
Merged
10 tasks
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@marcus7070 marcus7070 closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcus7070 @SuperSandro2000