Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: move extension derivations to separate dirs #100341

Merged
merged 25 commits into from Oct 14, 2020
Merged

php: move extension derivations to separate dirs #100341

merged 25 commits into from Oct 14, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 12, 2020

Motivation for this change

More cleaning up, also adding the new folder to the codeowners for the team

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu added 25 commits October 11, 2020 18:56
@etu
phpExtensions.apcu: Move to separate directory
0fc9ac2
@etu
phpExtensions.apcu_bc: Move to separate directory
bf5ca6b
@etu
phpExtensions.ast: Move to separate directory
021c6fe
@etu
phpExtensions.couchbase: Move to separate directory
649fdcd
@etu
phpExtensions.event: Move to separate directory
ad09650
@etu
phpExtensions.igbinary: Move to separate directory
6be3b07
@etu
phpExtensions.imagick: Move to separate directory
ba173b4
@etu
phpExtensions.mailparse: Move to separate directory
f8180fe
@etu
phpExtensions.maxminddb: Move to separate directory
df08b0f
@etu
phpExtensions.memcached: Move to separate directory
77224fd
@etu
phpExtensions.mongodb: Move to separate directory
4cae064
@etu
phpExtensions.oci8: Move to separate directory
1f00056
@etu
phpExtensions.pcov: Move to separate directory
98bc2f4
@etu
phpExtensions.pdo_sqlsrv: Move to separate directory
fd6db72
@etu
phpExtensions.php_excel: Move to separate directory
d5ea425
@etu
phpExtensions.pinba: Move to separate directory
58c1014
@etu
phpExtensions.protobuf: Move to separate directory
63e1505
@etu
php73Extensions.pthreads: Move to separate directory
b27b297
@etu
phpExtensions.rdkafka: Move to separate directory
80ba7d0
@etu
phpExtensions.redis: Move to separate directory
f5a4a96
@etu
phpExtensions.sqlsrv: Move to separate directory
a004e2c
@etu
phpExtensions.xdebug: Move to separate directory
e810b99
@etu
phpExtensions.yaml: Move to separate directory
6d0abdd
@etu
php: Drop usage of isPhp73 and isPhp74
3d31818 
These variables have bad names that doesn't really make full sense
@etu
CODEOWNERS: Add php-packages path to PHP team
7557bf0
@etu etu requested a review from a team October 12, 2020 15:36
@etu etu requested a review from edolstra as a code owner October 12, 2020 15:36
@ofborg ofborg bot requested review from aanderse and globin October 12, 2020 15:46
@ofborg ofborg bot requested review from Ma27 and talyz October 12, 2020 15:46
@etu etu merged commit 90a7b76 into NixOS:master Oct 14, 2020
@etu etu deleted the php-move-extension-derivations-to-separate-dirs branch October 14, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@etu