ldap: Use hashed passwords in the test #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to make use of the openldap modules for hashed passwords. In 20.03 the openldap expression didn't yet build those modules.
We should lead with good example and when users copy code from this repo it should not incentivize them to use plain text passwords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should lead with good example and when users copy code from this repo
it should not incentivize them to use plain text passwords.
I also had to update to nixos-20.09-small as that allows us to use the pw-sha2 ldap module in the test (they were not being built in the 20.03 version of the expression).
The 20.09 upgrade requires us to use breezy and not
bazaaras bazaar had been deprecated.