Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer: 2020-10-19 -> 2020-11-09 and fix build #101773

Merged
merged 4 commits into from Nov 9, 2020
Merged

rust-analyzer: 2020-10-19 -> 2020-11-09 and fix build #101773

merged 4 commits into from Nov 9, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Oct 26, 2020 •
edited

Motivation for this change

Bump version and fix #103009

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • broken -> 91.6M
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica
Copy link
Contributor Author

oxalica commented Nov 3, 2020

ping @jonringer for review

@ofborg ofborg bot requested a review from midchildan November 3, 2020 14:49
@oxalica
Copy link
Contributor Author

oxalica commented Nov 6, 2020

Blocked by #103009

@jonringer
Copy link
Contributor

looks like there's also conflicts now as well

@oxalica oxalica changed the title rust-analyzer: 2020-10-19 -> 2020-10-26 rust-analyzer: 2020-10-19 -> 2020-10-26 and fix build Nov 6, 2020
@oxalica
Copy link
Contributor Author

oxalica commented Nov 6, 2020

@jonringer Rebased and fixed build with rustc 1.47.0 on master

@austinbutler
Copy link
Member

Result of nixpkgs-review pr 101773 1

1 package failed to build:
  • lumo
25 packages built:
  • antora
  • castnow
  • epgstation
  • fast-cli
  • gtop
  • iosevka
  • joplin
  • mastodon-bot
  • mirakurun
  • netlify-cli
  • pm2
  • pulp
  • redoc-cli
  • rust-analyzer
  • rust-analyzer-unwrapped
  • thelounge
  • vimPlugins.coc-jest
  • vimPlugins.coc-prettier
  • vimPlugins.coc-snippets
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tslint
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen

@oxalica oxalica changed the title rust-analyzer: 2020-10-19 -> 2020-10-26 and fix build rust-analyzer: 2020-10-19 -> 2020-11-09 and fix build Nov 9, 2020
@Mic92 Mic92 merged commit f77eb9b into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@midchildan midchildan Awaiting requested review from midchildan

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust-analyzer build fails on latest master
4 participants
@oxalica @jonringer @austinbutler @Mic92