Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asterisk_18: Init at 18.0.0 #101761

Merged
merged 1 commit into from Nov 8, 2020
Merged

asterisk_18: Init at 18.0.0 #101761

merged 1 commit into from Nov 8, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Oct 26, 2020

I hope I bumped all attributes correctly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
asterisk_18: Init at 18.0.0
038793b 
I hope I bumped all attributes correctly.
@ofborg ofborg bot requested review from yorickvP and DerTim1 October 26, 2020 13:25
@ajs124 ajs124 merged commit bf4f302 into NixOS:master Nov 8, 2020
@ajs124 ajs124 deleted the init/asterisk18 branch November 8, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorickvP yorickvP Awaiting requested review from yorickvP

@DerTim1 DerTim1 Awaiting requested review from DerTim1

@Lassulus Lassulus Awaiting requested review from Lassulus

@ajs124 ajs124 Awaiting requested review from ajs124

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @ajs124