New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainer scripts: init check-hydra-by-maintainer.nix #101741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tried it on myself, it was a bit slow probably due to hydra rate limiting requests. Looks like the packagesWith
function is copied from maintainers/scripts/build.nix
, perhaps eventually we could have some standard library for querying package metadata.
$ nix-shell maintainers/scripts/check-hydra-by-maintainer.nix --argstr maintainer siraben
nix-shell -p hydra-check --run hydra-check cyclone-scheme knightos-kcc knightos-kimg knightos-kpack knightos-mkrom knightos-mktiupgrade knightos-patchrom knightos-scas knightos-z80e miranda mozwire python37Packages.swspotify python38Packages.swspotify swaglyrics the-powder-toy tilem
Build Status for nixpkgs.cyclone-scheme.x86_64-linux on unstable
✔ cyclone-0.21 from 2020-10-17 - https://hydra.nixos.org/build/128626648
Build Status for nixpkgs.knightos-kcc.x86_64-linux on unstable
✔ kcc-4.0.0 from 2020-10-17 - https://hydra.nixos.org/build/128637613
Build Status for nixpkgs.knightos-kimg.x86_64-linux on unstable
✔ kimg-0.3.0 from 2020-10-25 - https://hydra.nixos.org/build/129096700
Build Status for nixpkgs.knightos-kpack.x86_64-linux on unstable
✔ kpack-1.1.0 from 2020-10-17 - https://hydra.nixos.org/build/128629769
Build Status for nixpkgs.knightos-mkrom.x86_64-linux on unstable
✔ mkrom-1.0.2 from 2020-10-25 - https://hydra.nixos.org/build/129096239
Build Status for nixpkgs.knightos-mktiupgrade.x86_64-linux on unstable
✔ mktiupgrade-1.1.6 from 2020-10-25 - https://hydra.nixos.org/build/129096997
Build Status for nixpkgs.knightos-patchrom.x86_64-linux on unstable
✔ patchrom-1.1.3 from 2020-10-18 - https://hydra.nixos.org/build/128639452
Build Status for nixpkgs.knightos-scas.x86_64-linux on unstable
✔ scas-0.4.6 from 2020-10-17 - https://hydra.nixos.org/build/128617802
Build Status for nixpkgs.knightos-z80e.x86_64-linux on unstable
✔ z80e-0.5.0 from 2020-10-18 - https://hydra.nixos.org/build/128679490
Build Status for nixpkgs.miranda.x86_64-linux on unstable
✔ miranda-2.066 from 2020-10-18 - https://hydra.nixos.org/build/128625636
Build Status for nixpkgs.mozwire.x86_64-linux on unstable
✔ MozWire-0.5.2 from 2020-10-17 - https://hydra.nixos.org/build/128618575
Build Status for nixpkgs.python37Packages.swspotify.x86_64-linux on unstable
✔ python3.7-SwSpotify-1.2.1 from 2020-10-18 - https://hydra.nixos.org/build/128632961
Build Status for nixpkgs.python38Packages.swspotify.x86_64-linux on unstable
✔ python3.8-SwSpotify-1.2.1 from 2020-10-18 - https://hydra.nixos.org/build/128615712
Build Status for nixpkgs.swaglyrics.x86_64-linux on unstable
✔ swaglyrics-1.2.2 from 2020-10-18 - https://hydra.nixos.org/build/128622615
Build Status for nixpkgs.the-powder-toy.x86_64-linux on unstable
✔ the-powder-toy-95.0 from 2020-10-17 - https://hydra.nixos.org/build/128624368
Build Status for nixpkgs.tilem.x86_64-linux on unstable
✔ tilem-2.0 from 2020-10-22 - https://hydra.nixos.org/build/128854301
...
Thats true. My Nix is not that good yet. |
(sidenote: as soon as NixOS/hydra#743 is merged, we could simplify this. Unfortunately I need to find some time to implement a proper DB migration here first) |
3974d17
to
3cac098
Compare
I think hydra got a bit faster lately. |
So I'm sorry if I wasn't sufficiently clear last time, my PR in Hydra shouldn't block this PR. IIRC I briefly tested it last time and it appeared fine to me. So if someone else approves it, it should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
Tested:
- nix-shell maintainers/scripts/check-hydra-by-maintainer.nix --argstr maintainer _0x4A6F
Motivation for this change
There was no easy way to do this.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)