Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakounePlugins.rep: inherit from rep #101766

Merged
merged 1 commit into from Nov 2, 2020
Merged

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

rep is usable as a Kakoune plugin without changes, so inherit the attribute here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eraserhd
Copy link
Contributor Author

eraserhd commented Nov 2, 2020

@kevincox This is trivial and kakoune-related... Can you merge?

@kevincox
Copy link
Contributor

kevincox commented Nov 2, 2020

I don't know anything about kakoune but I agree that it is trivial enough.

@kevincox kevincox merged commit 8ab0db8 into NixOS:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants