Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustscan: fix build on darwin, set meta.platforms for maintainer Supersandro2000 #101745

Merged
merged 3 commits into from Oct 26, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

I want Hydra builds for my maintained packages.

Tested using nix-build maintainers/scripts/build.nix --argstr maintainer SuperSandro2000 on NixOS, Nix and Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Oct 26, 2020

I want Hydra builds for my maintained packages.

I can't see any of these not being built on hydra.

Most of these look to be go or rust and inherit their platforms from the respective builder, setting meta.platforms is redundant.

@r-burns
Copy link
Contributor

r-burns commented Oct 26, 2020

Ah! Thank you, that makes sense. So you only need the explicit platforms.all when it's a toplevel package?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Oct 26, 2020

Most of these look to be go or rust and inherit their platforms from the respective builder, setting meta.platforms is redundant.

I want a linter for such stuff which tells me yay or nay...

@zowoq Can you take another look please?

@SuperSandro2000 SuperSandro2000 changed the title Set meta.platforms for maintainer Supersandro2000 rustscan: fix build on darwin, set meta.platforms for maintainer Supersandro2000 Oct 26, 2020
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built rustscan on darwin.

@zowoq
Copy link
Contributor

zowoq commented Oct 26, 2020

So you only need the explicit platforms.all when it's a toplevel package?

Depends, some other package sets or builders will cover things like meta.platforms but others don't.

I want a linter for such stuff

A couple of people have written linters for checking various things but I don't think they would cover these packages. I might come up with something just to cover go and rust.

@zowoq zowoq merged commit fd29e9a into NixOS:master Oct 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the supersandro2000-meta-platforms branch October 26, 2020 12:16
@r-burns r-burns mentioned this pull request Oct 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants