New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustscan: fix build on darwin, set meta.platforms for maintainer Supersandro2000 #101745
rustscan: fix build on darwin, set meta.platforms for maintainer Supersandro2000 #101745
Conversation
I can't see any of these not being built on hydra. Most of these look to be go or rust and inherit their platforms from the respective builder, setting |
Ah! Thank you, that makes sense. So you only need the explicit platforms.all when it's a toplevel package? |
I want a linter for such stuff which tells me yay or nay... @zowoq Can you take another look please? |
b8bfd14
to
6c1c557
Compare
6c1c557
to
1de53fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built rustscan
on darwin.
Depends, some other package sets or builders will cover things like
A couple of people have written linters for checking various things but I don't think they would cover these packages. I might come up with something just to cover go and rust. |
Motivation for this change
I want Hydra builds for my maintained packages.
Tested using
nix-build maintainers/scripts/build.nix --argstr maintainer SuperSandro2000
on NixOS, Nix and Darwin.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)