Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s: add modprobe to k3s's PATH #101744

Merged
merged 1 commit into from Oct 28, 2020
Merged

k3s: add modprobe to k3s's PATH #101744

merged 1 commit into from Oct 28, 2020

Conversation

euank
Copy link
Member

@euank euank commented Oct 26, 2020

Otherwise we get warnings like 'level=warning msg="failed to start
br_netfilter module"' in k3s's logs, and it runs into networking issues.

Adding modprobe to k3s's PATH seems to fix the above.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (nixos/tests/k3s.nix)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@euank
k3s: add modprobe to k3s's PATH
7661b55 
Otherwise we get warnings like 'level=warning msg="failed to start
br_netfilter module"' in k3s's logs.

Adding modprobe to k3s's PATH fixes the warning at least. I'm not
certain if it fixes any real issue or not.
This was referenced Oct 26, 2020
Closed
Open
mweinelt
mweinelt approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@mweinelt mweinelt merged commit 9662e0e into NixOS:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@euank @mweinelt