Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s: 1.18.8+k3s1 -> 1.19.2-k3s1 #100150

Merged
merged 1 commit into from Oct 11, 2020
Merged

k3s: 1.18.8+k3s1 -> 1.19.2-k3s1 #100150

merged 1 commit into from Oct 11, 2020

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Oct 10, 2020

Motivation for this change

Update version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Maintainer: @euank

euank
euank approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that nix-build ./nixos/tests/k3s.nix passes with this change still too.

Thanks for updating the package!

@marsam marsam merged commit 29872df into NixOS:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euank euank euank approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theduke @euank @marsam @Janik-Haag