Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.dask: limit processes on tests, fix downstream #100167

Merged
merged 9 commits into from Oct 12, 2020
Merged

[20.09] python3Packages.dask: limit processes on tests, fix downstream #100167

merged 9 commits into from Oct 12, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 10, 2020 •
edited

Motivation for this change

backport #99575

includes some build fixes, but also makes some package much faster to review (specifically tensorly)

also backported #95824 to fix tensorflow_2 build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner October 10, 2020 18:01
raboof and others added 4 commits October 12, 2020 09:49
@raboof @jonringer
python3Packages.tensorflow_2: 2.1.0 -> 2.3.0
6b37755 
Also:
- patch to remove scipy requirement
- add cuda to RPATH
- don’t include nvidia_x11 (This isn’t needed, we can get it from
/run/opengl-driver being in the RPATH.)

Co-authored-by: Arnout Engelen <arnout@bzzt.net>
Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
(cherry picked from commit 1e19d44)
@matthewbauer @jonringer
python3Packages.tensorflow-estimator: 2.2.0 -> 2.3.0
07a4358 
(cherry picked from commit 74338f6)
@matthewbauer @jonringer
python3Packages.h5py: 2.9.0 -> 2.10.0
fcdd76e 
also disable on python 2.7
Co-authored-by: Jon <jonringer@users.noreply.github.com>

(cherry picked from commit 9cd240c)
@matthewbauer @jonringer
python3Packages.tensorflow: use cudatoolkit 11
c0af2ab 
(cherry picked from commit 59eecac)
@ofborg ofborg bot requested review from Rakesh4G and abbradar October 12, 2020 17:03
@jonringer
Copy link
Contributor Author

No regressions: other packages are already failing on release-20.09. Overall improvement

https://github.com/NixOS/nixpkgs/pull/100167
4 packages marked as broken and skipped:
python37Packages.qasm2image python37Packages.rl-coach python37Packages.tensorflowWithCuda python38Packages.qasm2image

6 packages failed to build:
python37Packages.clifford python37Packages.graph_nets python37Packages.optuna python37Packages.pymc3 python37Packages.tensorflow-bin python37Packages.tensorflow-bin_2

75 packages built:
python27Packages.tensorflow-estimator_2 python37Packages.Keras python37Packages.annoy python37Packages.arviz python37Packages.awkward python37Packages.baselines python37Packages.bayespy python37Packages.caffe python37Packages.datashader python37Packages.dcmstack python37Packages.dicom2nifti python37Packages.dipy python37Packages.dm-sonnet python37Packages.edward python37Packages.h5netcdf python37Packages.h5py python37Packages.h5py-mpi python37Packages.heudiconv python37Packages.hickle python37Packages.intake python37Packages.keras-applications python37Packages.mask-rcnn python37Packages.nibabel python37Packages.nilearn python37Packages.nipy python37Packages.nipype python37Packages.nitime python37Packages.phonopy python37Packages.pybids python37Packages.pywick python37Packages.qiskit python37Packages.qiskit-aqua python37Packages.sumo python37Packages.tensorflow python37Packages.tensorflow_2 python37Packages.tensorflow-estimator_2 python37Packages.tensorflow-probability python37Packages.tensorly python37Packages.tflearn python37Packages.uproot python37Packages.uproot-methods python37Packages.worldengine python38Packages.Keras python38Packages.annoy python38Packages.awkward python38Packages.bayespy python38Packages.caffe python38Packages.clifford python38Packages.datashader python38Packages.dicom2nifti python38Packages.dipy python38Packages.h5netcdf python38Packages.h5py python38Packages.h5py-mpi python38Packages.hickle python38Packages.intake python38Packages.keras-applications python38Packages.mask-rcnn python38Packages.nibabel python38Packages.nilearn python38Packages.nipy python38Packages.nipype python38Packages.phonopy python38Packages.pybids python38Packages.pywick python38Packages.qiskit python38Packages.qiskit-aqua python38Packages.sumo python38Packages.tensorflow_2 python38Packages.tensorflow-estimator_2 python38Packages.tensorly python38Packages.uproot python38Packages.uproot-methods worldengine-cli visidata

@jonringer jonringer merged commit 6c2310c into NixOS:release-20.09 Oct 12, 2020
@jonringer jonringer deleted the backport-python-dask branch October 12, 2020 19:07
@jonringer jonringer mentioned this pull request Oct 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@costrouc costrouc Awaiting requested review from costrouc

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @Rakesh4G @raboof @matthewbauer