Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicad #100065

Merged
merged 2 commits into from Oct 10, 2020
Merged

Kicad #100065

merged 2 commits into from Oct 10, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 9, 2020 •
edited

Motivation for this change

Modifies the kicad update script to use gitlab and updates kicad-unstable.

Things done

kicad-unstable now requires gtk3 as a build input to compile. I've also reformatted the files to have one parameter per line and one build input per line.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthuszagh matthuszagh requested a review from evils October 9, 2020 01:51
@doronbehar
Copy link
Contributor

There's a trailing space in update.sh. Other eval error has nothing to do with you.

@matthuszagh
kicad: modify update script to use gitlab for libraries
b67afd8 
Kicad libraries are now hosted on gitlab instead of github.
@matthuszagh
kicad-unstable: 2020-08-22 -> 2020-10-09
104aca9 
base.nix requires gtk3 to compile
@matthuszagh
Copy link
Contributor Author

@doronbehar trailing whitespace should now be fixed.

@doronbehar
Copy link
Contributor

@ofborg eval

@doronbehar doronbehar merged commit 967a01f into NixOS:master Oct 10, 2020
@matthuszagh matthuszagh deleted the kicad branch October 10, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@evils evils Awaiting requested review from evils

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @doronbehar