Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Document a workaround for using an FQDN as hostname #100151

Merged
merged 1 commit into from Oct 10, 2020
Merged

doc: Document a workaround for using an FQDN as hostname #100151

merged 1 commit into from Oct 10, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 10, 2020 •
edited

Since #76542 this workaround is required to use a FQDN as hostname. See
#94011 and #94022 for the related discussion. Due to some
potential/unresolved issues (legacy software, backward compatibility,
etc.) we're documenting this workaround 0.

Status

nixos-rebuild works but I couldn't test the NixOS manual due to:

error: a 'aarch64-linux' with features {} is required to build '/nix/store/1pppcxbi7m74j52fziprdx5q6mp1n8rs-options-docbook.xml.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

Either there must be a regression or nix-build nixos/release.nix -A manual isn't the correct command anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
doc: Document a workaround for using an FQDN as hostname
32e9ae5 
Since NixOS#76542 this workaround is required to use a FQDN as hostname. See
NixOS#94011 and NixOS#94022 for the related discussion. Due to some
potential/unresolved issues (legacy software, backward compatibility,
etc.) we're documenting this workaround [0].

[0]: NixOS#94011 (comment)
@primeos primeos added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 10, 2020
@primeos primeos mentioned this pull request Oct 10, 2020
Closed
@primeos primeos mentioned this pull request Oct 10, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

for the nixos manual, you need to specificy an architecture

nix-build nixos/release.nix -A manual.x86_64-linux

jonringer
jonringer approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

manual builds fine

nix-build ./nixpkgs/nixos/release.nix -A manual.x86_64-linux

@jonringer jonringer merged commit 4a600af into NixOS:master Oct 10, 2020
@jonringer jonringer mentioned this pull request Oct 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @jonringer