ZSH completion should be written like this #4132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous script was a script one needs to `source`. This script is a script one adds to their ZSH fpath. See: https://unix.stackexchange.com/a/33898/135796
|
Haven't seen nix-community/nix-zsh-completions#34 . Closing. |
|
Given the size of this completion script, I think it's nice to have it in the Nix codebase itself so that we have at least a simple completion works out-of-the box, so it's totally fine to reopen this imho |
|
Yes but it's not even installed, so it seems: Lines 14 to 17 in 20d2140 If this PR would also make it get installed, we'll have collisions in NixOS systems: non-NixOS users might benefit from this change (without making it get installed) but I would recommend them anyway to use nix-zsh-completions directly, so I don't care enough to maintain this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous script was a script one needs to
source. This script is a script one adds to their ZSH fpath. See:https://unix.stackexchange.com/a/33898/135796
cc @regnat
More over, Nixpkgs should chose this script here if
nixUnstableis used:https://github.com/NixOS/nixpkgs/blob/763bbfde7c3f3aa7f84b443b0c3fbbbd2c35f53e/nixos/modules/programs/zsh/zsh.nix#L281-L282