New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.google_cloud_dataproc: Fix package by adding missing dependencies #100138
Conversation
I think you might need to set |
You are right, it uses type annotations so it doesn’t parse on Python 2. Fixed, please take another look. |
Cool - this is working for me now, macos 10.14 & non-nixos linux x86_64. Could you squash the commits down to 1 per package please? |
I am adding this package because it is a dependency of google_cloud_dataproc.
I am adding this package because it is a dependency of google_cloud_dataproc.
17b938b
to
f922206
Compare
Yes, done. |
If you add
to |
...and that reveals that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 100138 1
7 packages built:
- python27Packages.proto-plus
- python37Packages.google_cloud_dataproc
- python37Packages.libcst
- python37Packages.proto-plus
- python38Packages.google_cloud_dataproc
- python38Packages.libcst
- python38Packages.proto-plus
Motivation for this change
ZHF: #97479
The package was broken because two of its dependencies were missing. They were not yet packaged, so I added both.
libcst
proto-plus
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)The ZHF issue says
But it is unclear to me if that is about this PR, or about the backporting one, so I’ll ping you here.