Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcsx2: multiple improvements #100162

Merged
merged 2 commits into from Oct 23, 2020
Merged

pcsx2: multiple improvements #100162

merged 2 commits into from Oct 23, 2020

Conversation

samuelgrf
Copy link
Member

Motivation for this change

Build pcsx2 with gtk3, this is already done on both Arch and Gentoo.
I updated the pcsx2 version to master, because it would otherwise crash with trace trap (core dumped) when opening menus.

I also enabled x86_64 builds, since it is supported on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hrdinka October 10, 2020 16:52
@samuelgrf samuelgrf force-pushed the pcsx2_gtk3-x86_64 branch 2 times, most recently from 442c19d to 7f20ffd Compare October 20, 2020 23:42
@samuelgrf samuelgrf changed the title pcsx2: build with gtk3 and support x86_64 builds pcsx2: multiple improvements Oct 20, 2020
@samuelgrf
Copy link
Member Author

The last commit enables building with LTO, this should be tested on darwin.

@hrdinka
Copy link
Contributor

hrdinka commented Oct 21, 2020

Thanks for the changes and sorry for not responding earlier. It somehow got lost in my mails and I completely missed this PR till today. I am currently on the road, but will give it a try and thorough look soon (hopefully tomorrow).

@hrdinka hrdinka merged commit 972ba80 into NixOS:master Oct 23, 2020
@hrdinka
Copy link
Contributor

hrdinka commented Oct 23, 2020

Tested locally. One less GTK2 App and a lot of gone problems, thanks for all the changes! 👍

@samuelgrf samuelgrf mentioned this pull request Nov 25, 2020
Closed
@samuelgrf samuelgrf deleted the pcsx2_gtk3-x86_64 branch March 5, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka Awaiting requested review from hrdinka

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelgrf @hrdinka @jtojnar