Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] bazel_0: fix build on darwin #100154

Merged
merged 1 commit into from Oct 10, 2020

Conversation

tricktron
Copy link
Member

Motivation for this change

Backport of #99967
ZHF: #97479
cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes `error: thread-local storage is not supported for the current target` by
upgrading clang_7 -> to clang_8 which supports thread-local storage.

(cherry picked from commit fd2c495)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 10, 2020
@ofborg ofborg bot requested a review from mboes October 10, 2020 15:13
@risicle
Copy link
Contributor

risicle commented Oct 10, 2020

WFM macos 10.14

@risicle risicle merged commit 9f16269 into NixOS:release-20.09 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants