New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always keep the CA derivations around #4139
Conversation
Workaround for NixOS#4138
Does this mean that CA derivations are never garbage-collected? |
They aren't until their output-path is (like if |
In fact, perhaps they should be kept around even if their output isn't. Suppose we have:
If we get rid of the row for We're going to need a pretty big migration I'm afraid to have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All that said, this PR makes the situation wholly better, and it is an easy enough stop-gap to back out of whenever we do do the sqlite overhaul.
I'm not 100% sure, but I think that the |
Ah, but |
Ah CI failed because of that annoying spurious failure. Do we have an issue for it? |
Oh yes because we only have this mapping for resolved drvs 🤔 |
But then derivations will accumulate forever... Or they could be treated like a cache and have some expiration policy. |
Workaround for #4138