Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdns-recursor: 4.3.3 -> 4.3.4 #100337

Merged
merged 2 commits into from Oct 12, 2020
Merged

pdns-recursor: 4.3.3 -> 4.3.4 #100337

merged 2 commits into from Oct 12, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

Version bump. Changelog is minimal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rnhmjoj October 12, 2020 15:02
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 12, 2020

I should have done this but can you add the NixOS test to passthru here as well? Thank you.

@aanderse
Copy link
Member Author

I should have done this but can you add the NixOS test to passthru here as well? Thank you.

You got it 👍

rnhmjoj
rnhmjoj approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@rnhmjoj rnhmjoj merged commit 47a3b4a into NixOS:master Oct 12, 2020
@aanderse aanderse deleted the pdns-recursor branch October 12, 2020 19:42
@mweinelt mweinelt mentioned this pull request Oct 13, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @rnhmjoj