Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: bb6dfa91c456
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 02d0df518ef3
Choose a head ref
  • 5 commits
  • 27 files changed
  • 2 contributors

Commits on Oct 31, 2020

  1. nixos/modules: fix systemd start rate-limits 

    These were broken since 2016:
systemd/systemd@f0367da
since StartLimitIntervalSec got moved into [Unit] from [Service].
StartLimitBurst has also been moved accordingly, so let's fix that one
too.

NixOS systems have been producing logs such as:
/nix/store/wf98r55aszi1bkmln1lvdbp7znsfr70i-unit-caddy.service/caddy.service:31:
Unknown key name 'StartLimitIntervalSec' in section 'Service', ignoring.

I have also removed some unnecessary duplication in units disabling
rate limiting since setting either interval or burst to zero disables it
(https://github.com/systemd/systemd/blob/ad16158c10dfc3258831a9ff2f1a988214f51653/src/basic/ratelimit.c#L16)
    @lf-
    lf- committed Oct 31, 2020
    Copy the full SHA
    b37bbca View commit details
    Browse the repository at this point in the history

  2. nixos/modules: Reformat warnings section

    @nh2
    nh2 committed Oct 31, 2020
    Copy the full SHA
    c178fe4 View commit details
    Browse the repository at this point in the history

  3. nixos/modules: deprecation warning for StartLimitInterval in [Service] 

    This implements
#45786 (comment)
    @lf- @nh2
    lf- authored and nh2 committed Oct 31, 2020
    Copy the full SHA
    644079e View commit details
    Browse the repository at this point in the history

  4. release notes: Document deprecation warning for StartLimitInterval in… 

    … [Service]
    @nh2
    nh2 committed Oct 31, 2020
    Copy the full SHA
    441abe9 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #97512 from lf-/StartLimitIntervalSec 

    nixos/modules: fix systemd start rate-limits
    @nh2
    nh2 committed Oct 31, 2020
    Copy the full SHA
    02d0df5 View commit details
    Browse the repository at this point in the history