Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that border-image-width extends into padding given no border area (e.g. via border-style: none) #26352

Merged
merged 2 commits into from Nov 6, 2021
Merged

Test that border-image-width extends into padding given no border area (e.g. via border-style: none) #26352

merged 2 commits into from Nov 6, 2021

Conversation

twilco
Copy link
Contributor

@twilco twilco commented Oct 31, 2020

When there is no border area (e.g. resulting from border-style: none), border-images with border-image-width should render into the padding / content area of the box.

Spec: https://www.w3.org/TR/2017/CR-css-backgrounds-3-20171017/#propdef-border-image-width

Editorial of the spec: w3c/csswg-drafts#655 (comment)

(emphasis mine)

Since by default a border image is only drawn in the border area, by default a border-style of none will make it disappear. However, the border-image-outset and border-image-width values can alter the “border” area into which the border image is drawn, extending it into the padding area (in the case of border-image-widths greater than the border-width) or extending it outside the border edge (in the case of border-image-outset greater than zero).

WebKit and Gecko exhibit this behavior, Chromium does not.

border-image-should-extend-into-padding

@twilco
[css-backgrounds] border-image-width should extend into padding given…
483372f 
… no border area (e.g. via border-style: none)
@twilco twilco force-pushed the border-image-width-should-extend-to-padding branch from 87efa32 to 483372f Compare October 31, 2020 17:35
nt1m
nt1m approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this behavior is correct. cc @dbaron or @fantasai to double-check

css/css-backgrounds/border-image-width-should-extend-to-padding.html Outdated Show resolved Hide resolved
@nt1m nt1m changed the title [css-backgrounds] border-image-width should extend into padding given no border area (e.g. via border-style: none) Test that border-image-width extends into padding given no border area (e.g. via border-style: none) Nov 6, 2021
@nt1m nt1m merged commit 3904336 into web-platform-tests:master Nov 6, 2021
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@twilco @Gabisampaio
Test that border-image-width extends into padding given no border are…
2167e07 
…a (e.g. via border-style: none) (web-platform-tests#26352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

@dbaron dbaron Awaiting requested review from dbaron

@fantasai fantasai Awaiting requested review from fantasai

Assignees

@fantasai fantasai

Labels
css-backgrounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twilco @nt1m @fantasai @wpt-pr-bot @moz-wptsync-bot