neovim: revert change to extraMakeWrapperArgs #102231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapNeovim incited users to use a list instead of a string. Revert that: the change is not super useful while breaking home-manager.
the compatibility layer for `wrapNeovim` introduced in NixOS#101265 broke the recommended way of configuration: https://nixos.org/manual/nixpkgs/stable/#custom-configuration https://nixos.wiki/wiki/Vim#Customizations restore the old ways.
10 tasks
|
@teto, The same problem (nix-community/home-manager#1577) cropped up for me today. This fixes it for me Thanks 👍 |
LnL7
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
I haven't been following the wrapper changes specifically, but this restores the current behaviour.
If you think the new approach should be encouraged the example is the manual should also be updated. Along with maybe some kind of warning when the fallback is used.
|
sure. New wrapper is still a work in progress so I will wait for its interface to stabilize before updating these. Merging then and sorry for the annoyance. |
|
Alright, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #101265 changed wrapNeovim to incite users to use a list instead of a string for extraMakeWrapperArgs. This reverts that since the change is not super useful (also I want the wrapper to be low-level so passing a string may actually make more sense) while breaking home-manager see nix-community/home-manager#1577
@SenchoPens does that fix your issue ?
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)