Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlterm: darwin support #102226

Merged
merged 3 commits into from Nov 7, 2020
Merged

mlterm: darwin support #102226

merged 3 commits into from Nov 7, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Oct 31, 2020 •
edited

Motivation for this change

Mlterm has Darwin support and I've been missing it.

Some things don't actually work on Darwin but disabling them doesn't change anything (not even closure size) and support for them may be added in future versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2020
@Atemu Atemu force-pushed the mlterm-darwin branch 2 times, most recently from 38afd7c to b9ff3b4 Compare October 31, 2020 12:47
@ofborg ofborg bot requested a review from vrthra October 31, 2020 13:15
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102226 run on x86_64-linux 1

1 package built:
  • mlterm

@marsam marsam merged commit 799f0cf into NixOS:master Nov 7, 2020
@Atemu Atemu deleted the mlterm-darwin branch March 12, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @SuperSandro2000 @marsam