Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8f2be9ac3608
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c409f694807e
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Oct 31, 2020

  1. pythonPackages.pip: make reproducible (#102222) 

    The previous attempt wasn't covering all of the bases. It relied on
invoking that pip-install-hook, and didn't apply to pip itself.

The core issue is that the generated .pyc files embed some of the
temporary paths, which are randomly generated. See
https://r13y.com/diff/bf8c3ca3148ebff9ecf41f294cc60b9f209c006d49699e356969ff32d736f1c6-8806a7cca91fdd300e48736bfcd57c4d0b54c1cc2fd61609f35143170862b59c.html

In this new attempt, the approach is to patch the TempFile
implementation directly, so that it creates stable temporary
directories. We also assume that if SOURCE_DATE_EPOCH is set, we are in
a scenario where reproducible builds are desirable and enter that
branch.

See also pypa/pip#7808
    @zimbatm
    zimbatm committed Oct 31, 2020
    Copy the full SHA
    c409f69 View commit details
    Browse the repository at this point in the history