-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel names not populating in "Trigger properties" dialogue (Rigol DS1054Z) #331
Comments
The blank entry is probably "external trigger" not "no channel". Moving this to scopehal since it looks like a bug in the library, not the GUI. |
Can you provide a screenshot of the main glscopeclient window without trigger properties open? |
There's supposed to be channel label buttons in the bottom left of each channel, as in this screenshot. What's interesting is that I'm not seeing sample rate information either. If you double-click that tiny blob do you get a channel properties dialog? And if you enter a name for the channel does it act somewhat more sane? |
Yep - I just see blank entries for all of those by default. I am able to click those label buttons and edit the channel name: And that channel name, in turn, appears to propagate to the trigger properties: (Also please tell me you're in Europe or somewhere east of Boston, MA - I'd hate to think I woke you up at quarter to 6 PST to talk trigger properties) |
I'm in the Seattle area, but my sleep schedule is destroyed from not having to wake up at a consistent time to go into the office for the past 6+ months :P I've actually been up since around 4AM Pacific time. So what this tells me is that the glscopeclient UI is correctly handling an empty channel name, and the Rigol driver is incorrectly supplying an empty name by default. When you open the channel properties dialog, under "scope" and "channel" do you see plausible values, or is the "channel" line above "display name" blank? |
I'm guessing you'd expect something like
That eases my mind a bit - I don't want to feel like I'm dragging you out of bed at godawful o'clock for this! You're certainly not alone on the sleeplessness front. I can't remember the last time I slept past 6 AM. How on earth is not having a regular job schedule making me wake up earlier?! |
Very interesting, so the hardware channel name is correct. The display name should default to the hardware channel name. I'm gonna have to do some digging here. |
Anything I can do to help? As an aside - I read thru the manual and saw some references to Siglent's scopes being based off of Teledyne Lecroy firmware. Would you expect Siglent's scopes to have better functionality with glscopeclient? (I'd love to pick your brain about this via email - got some questions I don't want to spam GitHub comments with - email me? You can reach me at @ gmail.com) |
IRC is best, join #scopehal on Freenode? I have to run and take care of somethign but will be back at my desk in half an hour or so. |
Never tried Freenode but there's a first time for everything - see you on there 👍 |
1af3ff8 should fix it, please test and close this issue if you can confirm the fix. |
The "din" menu is popping up empty for me. Running Ubuntu 20.04, connected over USBTMC to a Rigol DS1054Z.
Looks like the "din" channel name list has the right number of entries (one blank for no channel selected, and four more - one for each analog scope channel), but no names associated with them.
Perhaps
GetDisplayName()
is turning up blank for Rigol scopes? (Happy to check this behind the scenes if there's means of accessing that via CLI)https://github.com/azonenberg/scopehal-apps/blob/3752d10fc8a21ea60da8b81ed4c2f7ed17b7e665/src/glscopeclient/TriggerPropertiesDialog.cpp#L208
The text was updated successfully, but these errors were encountered: