New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the Systemd remote support #102244
Conversation
We should also first fix the default of |
9291275
to
6bc0acd
Compare
6bc0acd
to
6b30a9b
Compare
This should target It kinda backports the commtis from #102448 - even though it's not a real cherry-pick, but a logical backport, can we add the `(cherry picked from commit xxx) to the commit mesages, and align the commit messages themselves, to better cross-link this? |
0eb74a9
to
111e7d6
Compare
@flokli ok, i rewrote the history and based the branch onto Note the test is still building on my laptop... |
(cherry picked from commit 859a44e)
111e7d6
to
62eb243
Compare
Updated this to target |
(cherry picked from commit 81063ee)
62eb243
to
53024fb
Compare
Had to fix some indentation on the test, otherwise succeeded 👍 |
@flokli Cool, thank you! |
Motivation for this change
Since ae896e0, Systemd is no longer compiled with the http gateway because of an incompatibility between Systemd and libmicrohttpd. However, because of some updates, it is now building fine!
I also enable this feature is the systemd test to ensure the option services.journald.enableHttpGateway is working as excepted.
@flokli should i rebase these patches onto
staging-20.09
?Note I didn't run the systemd tests yet since a lot of things need to be rebuilt:/
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)