Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure: 1.10.1.645 -> 1.10.1.727 #102272

Merged
merged 1 commit into from Nov 9, 2020
Merged

clojure: 1.10.1.645 -> 1.10.1.727 #102272

merged 1 commit into from Nov 9, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

newest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 31, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from jlesquembre October 31, 2020 21:17
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102272 run on x86_64-linux 1

2 packages built:
  • clojure
  • lumo

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2020 •
edited

Result of nixpkgs-review pr 102272 run on x86_64-darwin 1

1 package failed to build:
  • lumo
1 package built:
  • clojure
  touch /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.target/node_dtrace_header.stamp
  touch /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.target/node_dtrace_ustack.stamp
  touch /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.target/node_dtrace_provider.stamp
  touch /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.target/node_etw.stamp
  touch /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.target/specialize_node_d.stamp
  rm -f /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/deps/v8/gypfiles/libv8_libbase.a && ./gyp-mac-tool filter-libtool libtool  -static -o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/deps/v8/gypfiles/libv8_libbase.a /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/bits.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/cpu.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/division-by-constant.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/file-utils.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/functional.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/ieee754.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/logging.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/once.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/page-allocator.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/condition-variable.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/mutex.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/semaphore.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/time.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/sys-info.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/utils/random-number-generator.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace_posix.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/platform-macos.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/platform-posix.o /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/v8_libbase/deps/v8/src/base/platform/platform-posix-time.o
/bin/sh: ./gyp-mac-tool: /usr/bin/env: bad interpreter: Operation not permitted
make[1]: *** [deps/v8/gypfiles/v8_libbase.host.mk:177: /private/tmp/nix-build-lumo-1.10.1.drv-0/lumo/tmp/node/11.13.0/out/Release/obj.host/deps/v8/gypfiles/libv8_libbase.a] Error 126
make[1]: *** Waiting for unfinished jobs....
../deps/gtest/src/gtest.cc:376:12: warning: missing field 'owner_' initializer [-Wmissing-field-initializers]
GTEST_API_ GTEST_DEFINE_STATIC_MUTEX_(g_linked_ptr_mutex);
           ^
../deps/gtest/include/gtest/internal/gtest-port.h:1949:80: note: expanded from macro 'GTEST_DEFINE_STATIC_MUTEX_'
     ::testing::internal::MutexBase mutex = { PTHREAD_MUTEX_INITIALIZER, false }
                                                                               ^
1 warning generated.
rm 07fb4597d0c54d7b34e15c094b2443958eca7905.intermediate
make: *** [Makefile:100: node] Error 2
....> ERROR: The release executable has not been generated. This indicates a failure in the build process. There is likely additional information above.

@bennyandresen
Copy link
Contributor Author

gyp-mac-tool: /usr/bin/env: bad interpreter: Operation not permitted

Could this be a problem with Mac OS Catalina? I see reports about that by googling for that error.
In any case we need to wait someone with darwin experience to debug this further, as I only have access to x86-64 linux.

@SuperSandro2000
Copy link
Member

Could this be a problem with Mac OS Catalina?

Could be. We can also disable it for darwin for now.

@bennyandresen
Copy link
Contributor Author

Could be. We can also disable it for darwin for now.

Okay. That would have to be a different PR, because the lumo problem is not a clojure problem, AFAICS.

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 4, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@jlesquembre
Copy link
Member

Okay. That would have to be a different PR, because the lumo problem is not a clojure problem, AFAICS.

I agree, lumo issues have nothing to do with this PR.
Also, lumo was abandoned, his creator moved away from the clojure ecosystem, and said he has no intention to maintain it (see anmonteiro/lumo#492 (comment))

I think we should remove lumo from nixpkgs at some point (it was removed from homebrew, see Homebrew/homebrew-core@f052092). In my opinion, graalvm and babashka are better alternatives to lumo, and I don't see a reason - for new projects - to pick lumo over it. I'd like to know @hlolli opinion about it, does make sense to you to continue maintaining lumo?

@bennyandresen
Copy link
Contributor Author

bennyandresen commented Nov 7, 2020 •
edited

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 7, 2020 23:04
@alyssais alyssais merged commit 29038ac into NixOS:master Nov 9, 2020
@bennyandresen bennyandresen deleted the clojure_1.10.1.645-1.10.1.727 branch November 11, 2020 21:30
@jlesquembre jlesquembre mentioned this pull request Dec 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre jlesquembre approved these changes

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bennyandresen @SuperSandro2000 @jlesquembre @alyssais