Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-app-engine-go-sdk,google-cloud-sdk,google-compute-engine: Refactor to python3 #102284

Merged
merged 3 commits into from Nov 1, 2020
Merged

google-app-engine-go-sdk,google-cloud-sdk,google-compute-engine: Refactor to python3 #102284

merged 3 commits into from Nov 1, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Working on #101964, focusing here on google tools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy changed the title Refactor google to python3 google-app-engine-go-sdk,google-cloud-sdk,google-compute-engine: Refactor to python3 Oct 31, 2020
@ofborg ofborg bot requested a review from lufia October 31, 2020 22:28
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102284 run on x86_64-darwin 1

2 packages built:
  • google-app-engine-go-sdk
  • google-cloud-sdk (google-cloud-sdk-gce)

jonringer
jonringer reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

othewise LGTM

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/102284
3 packages built:
google-app-engine-go-sdk google-cloud-sdk google-compute-engine

@jonringer jonringer merged commit 4fe0ea4 into NixOS:master Nov 1, 2020
@freezeboy freezeboy deleted the refactor-google-to-python3 branch November 1, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@lufia lufia Awaiting requested review from lufia

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @jonringer