check-esxi-hardware: refactor from python2 to python3 #102282
Conversation
|
Result of 12 packages built:
|
|
Result of 12 packages built:
|
| @@ -27,7 +27,7 @@ in python2Packages.buildPythonApplication rec { | |||
| runHook postInstall | |||
| ''; | |||
|
|
|||
| propagatedBuildInputs = with python2Packages; [ pywbem ]; | |||
| propagatedBuildInputs = with python3Packages; [ pywbem requests ]; | |||
There was a problem hiding this comment.
| propagatedBuildInputs = with python3Packages; [ pywbem requests ]; | |
| propagatedBuildInputs = with python3Packages; [ pywbem requests setuptools ]; |
[nix-shell:~/.cache/nixpkgs-review/pr-102282]$ ./results/check-esxi-hardware/bin/check_esxi_hardware.py --help
Traceback (most recent call last):
File "/nix/store/fx2jz12qvfvv3q4ckwqbzyrfgis67sdz-check-esxi-hardware-20200710/bin/.check_esxi_hardware.py-wrapped", line 290, in <module>
import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
There was a problem hiding this comment.
Lets take this opportunity to add a simple test for that:
checkPhase = ''
$out/bin/check_esxi_hardware.py --help
'';
There was a problem hiding this comment.
setuptools is a default build dependency, so this test will always succeed during a build, regardless of whether setuptools is available during runtime outside a build. Note this is also a bit of an issue with pythonImportsCheck and all tests.
There was a problem hiding this comment.
you might be able to do something like:
checkPhase = ''
unset PYTHONPATH
$out/bin/check_esxi_hardware.py --help
'';
|
|
||
| let | ||
| bName = "check_esxi_hardware"; | ||
| pName = stdenv.lib.replaceStrings [ "_" ] [ "-" ] bName; | ||
|
|
||
| in python2Packages.buildPythonApplication rec { | ||
| in python3Packages.buildPythonApplication rec { |
There was a problem hiding this comment.
There is an executable that is installed that has an extension, please remove the extension. Executables in /bin should not have any.
freezeboy
force-pushed
the
update-check-esxi-hardware
branch
2 times, most recently
from
0695491
to
b1ec9db
Compare
|
I really want to try this out but we have this check deployed on many locations so I need to be sure it doesn't break anything. Has anyone tried this against actual ESXi instances? |
|
|
Thanks @jonringer - it wasn't so much about "how" to try it out but more if anyone had actually given this a go. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@freezeboy Can you resolve the merge conflict? |
freezeboy
force-pushed
the
update-check-esxi-hardware
branch
from
b1ec9db
to
d44abad
Compare
There was a problem hiding this comment.
LGTM
shows usage
https://github.com/NixOS/nixpkgs/pull/102282
13 packages built:
check-esxi-hardware python27Packages.nocasedict python27Packages.nocaselist python27Packages.pywbem python27Packages.yamlloader python37Packages.nocasedict python37Packages.nocaselist python37Packages.pywbem python37Packages.yamlloader python38Packages.nocasedict python38Packages.nocaselist python38Packages.pywbem python38Packages.yamlloader
if there was an issue with the interpreter, it's usually very apparent |
Motivation for this change
Working on issue: #101964
I took the opportunity to update the dependencies to support python3
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)