Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upterm: init at 0.4.6 #102276

Closed
wants to merge 1 commit into from
Closed

upterm: init at 0.4.6 #102276

wants to merge 1 commit into from

Conversation

gilligan
Copy link
Contributor

Motivation for this change

Add upterm to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit October 31, 2020 21:32
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102276 run on x86_64-linux 1

1 package built:
  • upterm

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2020 •
edited

Result of nixpkgs-review pr 102276 run on x86_64-darwin 1

1 package failed to build:
  • upterm
PASS
ok      github.com/owenthereal/upterm/cmd/upterm/command        0.016s
time="2020-11-01T00:05:18Z" level=fatal msg="listen tcp 127.0.0.1:0: bind: operation not permitted"
FAIL    github.com/owenthereal/upterm/ftests    0.015s
FAIL

@gilligan
Copy link
Contributor Author

gilligan commented Nov 7, 2020

@SuperSandro2000 sorry for the long lack of updates. I added myself as maintainer and disabled the tests.

sikmir
sikmir reviewed Nov 16, 2020
View reviewed changes
pkgs/tools/misc/upterm/default.nix
sha256 = "1p7bwg8zlp45j5758wfbkpc95rpsa8xq0hn439bd2knrdsdadnnk";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comment why check disabled.

SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/tools/misc/upterm/default.nix
description = "secure terminal-session sharing";
homepage = "https://upterm.dev";
license = licenses.asl20;
maintainers = [ maintainers.gilligan ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ maintainers.gilligan ];
maintainers = with maintainers; [ gilligan ];

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102276 run on x86_64-darwin 1

1 package built:
  • upterm

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102276 run on x86_64-linux 1

1 package built:
  • upterm

@gilligan gilligan closed this Nov 23, 2020
@gilligan gilligan deleted the add-upterm branch November 23, 2020 21:56
@gilligan
Copy link
Contributor Author

Thanks to those who provided feedback but i don’t intend to use/maintain this package anymore. Feel free to pick this up if you would like to maintain it.

@hax404 hax404 mentioned this pull request Feb 7, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gilligan @SuperSandro2000 @sikmir