Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: make ImageMagick dependency optional in Emacs≥27 #102241

Merged
merged 1 commit into from Nov 20, 2020
Merged

emacs: make ImageMagick dependency optional in Emacs≥27 #102241

merged 1 commit into from Nov 20, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 31, 2020

Motivation for this change

Emacs 27 doesn't use ImageMagick by default to display images [1]:

** Emacs no longer defaults to using ImageMagick to display images.
This is due to security and stability concerns with ImageMagick.  To
override the default, use 'configure --with-imagemagick'.

[1] https://github.com/emacs-mirror/emacs/blob/emacs-27.1/etc/NEWS#L96-L98

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
emacs: make ImageMagick dependency optional in Emacs≥27
ed047f8 
Emacs 27 doesn't use ImageMagick by default to display images [1]:

    ** Emacs no longer defaults to using ImageMagick to display images.
    This is due to security and stability concerns with ImageMagick.  To
    override the default, use 'configure --with-imagemagick'.

[1] https://github.com/emacs-mirror/emacs/blob/emacs-27.1/etc/NEWS#L96-L98
@ofborg ofborg bot requested review from jwiegley and peti October 31, 2020 16:14
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 31, 2020 •
edited

Result of nixpkgs-review pr 102241 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • agdaPackages.iowa-stdlib
1 package failed to build:
  • cedille
27 packages built:
  • aerc
  • afew
  • agdaPackages.agda-categories
  • agdaPackages.agda-prelude
  • agdaPackages.cubical
  • agdaPackages.functional-linear-algebra
  • agdaPackages.generic
  • agdaPackages.standard-library
  • auctex
  • cscope
  • emacs (emacs27)
  • emacs26
  • framac
  • haskellPackages.agda-unused
  • lieer
  • mu
  • muchsync
  • neomutt
  • notmuch
  • notmuch-addrlookup
  • pydb
  • python27Packages.notmuch
  • python37Packages.notmuch
  • python38Packages.notmuch
  • recutils
  • rtags
  • why3

Already broken on master:

/private/tmp/nix-build-cedille-1.1.1.drv-0/source/src/to-string.agda:103,1-86
Could not parse the pattern synonym
cedille-options.options.mk-options _ _ _ _ ff _ _ _ ff _
Operators used in the grammar:
  None
when scope checking the declaration
  pattern ced-ops-drop-spine = cedille-options.options.mk-options _ _
                               _ _ ff _ _ _ ff _
make: *** [Makefile:136: cedille] Error 1

@marsam marsam merged commit a449934 into NixOS:master Nov 20, 2020
@marsam marsam deleted the emacs27-optional-imagemagick branch November 20, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

@jwiegley jwiegley Awaiting requested review from jwiegley

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @SuperSandro2000