New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
greetd: init at 0.7.0 #102242
greetd: init at 0.7.0 #102242
Conversation
Related: #102225 |
Should I move the packages to |
Argh you beat me to WRT
It does manage the actual session managers and so is a part of that system, I'd say it's fine to put it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs #102225 merged, mobule possibly needs to be moved (where do wayland based DMs go?)
d6ef0b9
to
03f4e08
Compare
@luc65r I have a module ready to go: greetd.nix.
Technically greetd is not wayland-based and makes no assumptions about either the greeter or the session (relevant quote from the docs: "If you can run it from your shell in a TTY, greetd can start it"). That doesn't really make classification easier though. I guess |
@Qzle Sure!
That was my reasoning, I guess it doesn't really matter where it is. |
If possible and agreeable I would put all of the greeters (gtkgreet, wlgreet, etc..) under the |
Aside from the conflict, what else is stopping this from getting merged? |
Great idea! I will do it as soon as possible.
After that, nothing. |
Wow, @luc65r, that's awesome stuff! Especially adding all those greeters! Fantastic, thank you! 😄 |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 5 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is awesome @luc65r, looking forward to the modules landing! |
I second @lovesegfault, this is awesome. Thank you so much! |
Motivation for this change
Wanted to package greetd and friends
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)