Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-mediate: remove broken #102243

Merged
merged 1 commit into from Nov 1, 2020
Merged

git-mediate: remove broken #102243

merged 1 commit into from Nov 1, 2020

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Oct 31, 2020

After update to 1.0.8.1 git-mediate is buildable again

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@KaiHa Thanks for trying to fix this.

Could you follow the steps in this video for marking Haskell packages as non-broken:

https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968

@KaiHa
haskellPackages.git-mediate: mark as not broken
3640055 
After update to 1.0.8.1 git-mediate is buildable again
@KaiHa KaiHa changed the base branch from master to haskell-updates November 1, 2020 09:31
@KaiHa
Copy link
Contributor Author

KaiHa commented Nov 1, 2020

@cdepillabout Thanks for pointing me in the right direction. AFAICT I have done the necessary changes now. Do you by chance know how backporting to 20.09 would work?

@cdepillabout cdepillabout merged commit c523875 into NixOS:haskell-updates Nov 1, 2020
@cdepillabout
Copy link
Member

Yup, this builds alright on x86-64-linux. Thanks!

Do you by chance know how backporting to 20.09 would work?

The release-20.09 branch doesn't get its Haskell packages updated automatically, so in addition to the change you have here currently, you'll also have to edit the derivation directly in pkgs/development/haskell-modules/hackage-packages.nix and remove broken = true;.

Feel free to send a PR with what you can figure out and ping me. I'll let you know if there is anything else that needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaiHa @cdepillabout