Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/firefox: add audio subtest #102249

Merged
merged 1 commit into from Oct 31, 2020
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 31, 2020

Motivation for this change

Avoid issue #79310 happening again.

This PR adds a very basic but useful sound check: it sets up a loopback device
as default audio output and records any sound. Then plays a sample sound using
firefox and checks if the sound is recorded back.

Things done

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test runs successfully, generates result/screen.png and result/record.wav (which does indeed play the "phone ringing" sound).

nixos/tests/firefox.nix Outdated Show resolved Hide resolved
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you very much!

Can you also fix the mentioned type annotation that @cole-h pointed out?

@andir andir merged commit fd0b383 into NixOS:master Oct 31, 2020
@rnhmjoj rnhmjoj deleted the firefox-audio branch July 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants