[20.09] ipfs: Add 0.7.0 in addition #100676
Conversation
IPFS would complain with warnings like Configuration file /nix/store/...-ipfs-0.6.0/etc/systemd/system/ipfs.service is marked executable. Please remove executable permission bits. Proceeding anyway. (cherry picked from commit 1a382e9)
Trying to move a directory into itself will result in a warning: mv: cannot move 'ipfs-src' to a subdirectory of itself, 'ipfs-src/ipfs-src' This can be prevented by excluding that directory. (cherry picked from commit d385065)
IPFS has been evolving quite fast lately, so I think tracking new release in stable NixOS is prudent. (cherry picked from commit b75e431)
|
Given that the two files for the two versions are identical except for the version and the hash, would it make sense to somehow combine the two? |
|
Is there a particular reason to split the IPFS package into two version releases? |
|
@Luflosi I thought about that, but I feel seeing that this is just on a release branch with bounded life, it would be a premature abstraction not with the effort. Also, suppose 0.8 comes out before 21.03 requiring more invasive changes? [Conversely, I think the more permanent duplication of LLVMs, GCCs, etc. is a problem, and deduplicating those would be a great use of time.]
OK, will merge. @fabianhjr I don't want to bump the default major version on a stable branch, that's all. |
IPFS evolves quite fast. The network protocol is compatible, but we don't want to force migrations on stable, so we add a new version instead. See NixOS#100676 for last time we did this. (Adapted from from commit d96ccfa)
Motivation for this change
IPFS has been evolving quite fast lately, so I think tracking new release in stable NixOS is prudent.
CC @Luflosi
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)