Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burpsuite: 2020.1 -> 2020.9.2 #100677

Closed
wants to merge 2 commits into from
Closed

burpsuite: 2020.1 -> 2020.9.2 #100677

wants to merge 2 commits into from

Conversation

buckley310
Copy link
Contributor

Motivation for this change

Update Burpsuite to the latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@buckley310
Copy link
Contributor Author

Upon further testing, the new "embedded browser" feature is not working. Looking into this...

@buckley310 buckley310 marked this pull request as draft October 16, 2020 06:20
@buckley310
Copy link
Contributor Author

@bennofs what do you think of this fix?

As far as I can tell, the next-best option would be using an FHSUserEnv. Patching the jar does not seem practical.

@buckley310 buckley310 marked this pull request as ready for review October 16, 2020 17:40
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100677 run on x86_64-linux 1

1 package built:
  • burpsuite

@bennofs
Copy link
Contributor

bennofs commented Nov 27, 2020

Oh, I couldn't get the embedded browser working myself. Nice to see that you managed to do it, I think the fix is ok 👍

@buckley310
Copy link
Contributor Author

I have updated the PR so that it automatically reads the embedded chromium version at runtime.

@buckley310 buckley310 mentioned this pull request Dec 30, 2020
Merged
10 tasks
@buckley310 buckley310 closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@bennofs bennofs bennofs requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buckley310 @SuperSandro2000 @bennofs