Boot GUI: only show relevant reboot options #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll think it over for how we want to handle custom reboot commands, but some platforms (e.g. u-boot, depthcharge, qemu) don't and can't use them. A goal is to keep stage-2 as generic as possible, so building into it some knowledge of this is harder. At any rate, the user can still reboot, and hold the key combo as needed!
This will be used by the boot GUI to only show relevant reboot options. We might add other HAL-ish things in there. Note that this is all internal stuff :)
This way we can clean up the recovery menu from useless options. Furthermore, if a device in the future gives us more option, we can implement them.
|
Implementation detail note: The goal here is that in Nix, only generic labels are used to represent options that the HAL knows how to handle. So the current implementation is an implementation detail, and could change in the future, while leaving the interface (those labels) as they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "HAL" options layer where we can describe some hardware-specific abstractions.
The only one implemented for now is the reboot modes list.
This list is interpreted by the boot GUI in an implementation-defined way. All of the implementation details are internal and could change at any time for now.
The goal is to make sure that, e.g. on the Pinephone, the reboot options that don't apply are not present.