nixos/nginx: Do not remove headers while proxying #100708
Conversation
Removing the `Accept-Encoding` header breaks applications which may produce already compressed content. Removing this header is staded in the nginx docs but is ment as an example, not as an recomendation.
|
Indeed, a client could tell the server that it accepts a certain encoding, but what would never reach the upstream. Why would an upstream application then use compression? I'm not an nginx expert, but couldn't nginx handle the |
My specific use-case is OctoPrint. They can serve already gzipped asset bundles if the encoding is enabled. If the encoding is not set, the decompress the bundle on the fly and serve it uncompressed - resulting in a higher load and response time.
AFAIK, proxy requests will not be compressed in default config. There is |
Backends should be able to serve compressed content through Nginx. The setting, which is removed here, prevented that. We noticed the problem for the statshost location proxy which sent metrics uncompressed since the upgrade. On 15.09, compression was done by telegraf. This is also fixed in NixOS unstable: NixOS/nixpkgs#100708 #PL-129611
Motivation for this change
Removing the
Accept-Encodingheader breaks applications which mayproduce already compressed content.
Removing this header is staded in the nginx docs but is ment as an
example, not as an recomendation.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)