Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: update xcode versions #100687

Merged
merged 4 commits into from Jan 24, 2021
Merged

darwin: update xcode versions #100687

merged 4 commits into from Jan 24, 2021

Conversation

spease
Copy link
Contributor

@spease spease commented Oct 16, 2020

Motivation for this change

All XCode versions listed are quite old

Things done

'hello' should build, but this needs more comprehensive testing imho.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/compiling-for-ios/10776/1

@spease
Copy link
Contributor Author

spease commented Jan 5, 2021

Bump. I wonder also if there might be a way to get requireXcode accessible externally, so that overrideAttrs could be used to add new versions too.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-create-custom-cross-compile-overlay/10832/3

@jonringer
Copy link
Contributor

cc @NixOS/darwin-maintainers

@jonringer jonringer changed the title Add newer xcode versions darwin: update xcode versions Jan 6, 2021
@jonringer
Copy link
Contributor

I would change the commit message to be darwin: update xcode versions , as that's more inline with the changes you are proposing

@spease
Copy link
Contributor Author

spease commented Jan 6, 2021

I haven't done this on github, would I amend and force-push the local branch, or push another commit, or is the rename to the ticket name enough? There are some newer versions that I can add to this.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trying-to-get-ios-working/10991/1

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 20, 2021
@spease spease mentioned this pull request Jan 20, 2021
Merged
9 tasks
@spease
Copy link
Contributor Author

spease commented Jan 20, 2021 via email

@matthewbauer matthewbauer merged commit 84408a6 into NixOS:master Jan 24, 2021
@spease spease deleted the add-newer-xcode-hashes branch January 24, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@nbp nbp Awaiting requested review from nbp

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spease @nixos-discourse @jonringer @matthewbauer