Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.fifo: fix level on fifo full #524

Merged
merged 1 commit into from Nov 3, 2020

Conversation

anuejn
Copy link
Contributor

@anuejn anuejn commented Nov 3, 2020

This is the split out stuff from #512 that affects AsyncFIFO and not AsyncFIFOBuffered

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #524 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   81.38%   81.32%   -0.07%     
==========================================
  Files          49       49              
  Lines        6414     6414              
  Branches     1282     1282              
==========================================
- Hits         5220     5216       -4     
- Misses       1005     1009       +4     
  Partials      189      189              
Impacted Files Coverage Δ
nmigen/lib/fifo.py 93.93% <100.00%> (ø)
nmigen/back/rtlil.py 80.80% <0.00%> (-0.62%) ⬇️
nmigen/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781a3aa...c2e4567. Read the comment docs.

@whitequark whitequark merged commit c7014f8 into amaranth-lang:master Nov 3, 2020
@whitequark
Copy link
Member

Thanks!

@anuejn anuejn deleted the fifo_overflow_fix branch November 3, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants