Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild: Move to backup file to change LICENSE to lowercase. #102579

Merged
merged 1 commit into from Nov 7, 2020
Merged

MSBuild: Move to backup file to change LICENSE to lowercase. #102579

merged 1 commit into from Nov 7, 2020

Conversation

moinessim
Copy link
Contributor

@moinessim moinessim commented Nov 3, 2020 •
edited

Motivation for this change

I got this error while installing fsharp41, which depends on msbuild.

mv: 'LICENSE' and 'license' are the same file
builder for '/nix/store/kyqil2bm40m4ngz8shjyz64156wl6yfg-msbuild-16.3+xamarinxplat.2019.07.26.14.57.drv' failed with exit code 1

Tried to use use-case-hack = true in nix.conf with no success (I'm using nix-darwin).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marius851000
Copy link
Contributor

I suggest you change the title to mention msbuild or something similar. Maybe ping FSharp maintainers ? (it seem I can't ping the msbuild's one)

@moinessim moinessim changed the title Move to backup file to change LICENSE to lowercase. MSBuild: Move to backup file to change LICENSE to lowercase. Nov 3, 2020
@moinessim
Copy link
Contributor Author

Thanks @marius851000.
Hi, @thoughtpolice and @7c6f434c.
Would you be able to help merge this one?
Thanks!

@7c6f434c 7c6f434c merged commit 434d967 into NixOS:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moinessim @marius851000 @7c6f434c