Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.compiler.ghc8102BinaryMinimal: init #102614

Merged
merged 1 commit into from Nov 3, 2020
Merged

haskell.compiler.ghc8102BinaryMinimal: init #102614

merged 1 commit into from Nov 3, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 3, 2020

To stay within hydra limit of 2^31 output size on aarch64-linux

Motivation for this change

See #102504

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
haskell.compiler.ghc8102BinaryMinimal: init
f8ad73b 
To stay within hydra limit of 2^31 output size on aarch64-linux
@roberth roberth mentioned this pull request Nov 3, 2020
Merged
12 tasks
@vcunat vcunat merged commit a31fd3c into NixOS:staging-next Nov 3, 2020
@vcunat
Copy link
Member

vcunat commented Nov 3, 2020 •
edited

Builds OK; quick check on sizes also seems OK, both for bootstrap and the default ghc.

@FRidh
Copy link
Member

FRidh commented Nov 4, 2020

This seems to have broken eval.

@vcunat
Copy link
Member

vcunat commented Nov 4, 2020

@FRidh: eval of what? At a quick glance I can't see any problem – on Hydra or locally.

@roberth
Copy link
Member Author

roberth commented Nov 4, 2020 •
edited

This seems to have broken eval.

This was rebased on #102539 which wasn't ported to here. I've cherry-picked it directly to staging-next just now because ofborg fails anyway due to the old revision being bad.

@vcunat
Copy link
Member

vcunat commented Nov 4, 2020

We have binaries for ghc.aarch64 on nixpkgs master: https://hydra.nixos.org/build/129602285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @vcunat @FRidh