Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nats-server: 2.1.7 -> 2.1.9 #102623

Merged
merged 1 commit into from Nov 9, 2020
Merged

nats-server: 2.1.7 -> 2.1.9 #102623

merged 1 commit into from Nov 9, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 3, 2020

Motivation for this change
Folks,

The NATS project has a new advisories website:
  <https://advisories.nats.io/>

We also have two new CVEs; both relate to our JWT handling and both
affect the NATS server:

* CVE-2020-26521
  + Nil deref in JWT library, causing Go panic
  + NATS server upgrade required to avoid Denial-of-Service
  + 2020-11-02
* CVE-2020-26892
  + Incorrect credential expiration handling via JWT library
  + API fixes needed by library users
  + NATS server upgrade required for expiration to work
  + 2020-11-02

The text of our advisories should be attached.

We have just released NATS server 2.1.9 which includes the fixes for
both these issues.

Regards,
-Phil Pennock

https://www.openwall.com/lists/oss-security/2020/11/02/2

Supersedes #97205.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 3, 2020
@ofborg ofborg bot requested a review from swdunlop November 3, 2020 13:25
@braunse
Copy link
Contributor

braunse commented Nov 3, 2020 •
edited

On Debian:

Result of nixpkgs-review pr 102623 1

1 package built:
  • nats-server

@braunse
Copy link
Contributor

braunse commented Nov 3, 2020 •
edited

On NixOS 20.09:

Result of nixpkgs-review pr 102623 1

1 package built:
  • nats-server

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102623 run on x86_64-darwin 1

1 package built:
  • nats-server

@alyssais alyssais merged commit b2a20c2 into NixOS:master Nov 9, 2020
@mweinelt mweinelt deleted the nats branch November 9, 2020 15:12
This was referenced Nov 9, 2020
Merged
Merged
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swdunlop swdunlop Awaiting requested review from swdunlop

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @braunse @SuperSandro2000 @alyssais