Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3: 4.18.2 -> 4.18.3 #102615

Merged
merged 1 commit into from Nov 3, 2020
Merged

i3: 4.18.2 -> 4.18.3 #102615

merged 1 commit into from Nov 3, 2020

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented Nov 3, 2020 •
edited

Motivation for this change

Fixes #99197

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and globin November 3, 2020 12:14
@teto teto merged commit e90cfc7 into NixOS:master Nov 3, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020 •
edited

Result of nixpkgs-review pr 102615 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • python37Packages.py3status
  • python38Packages.py3status
5 packages failed to build:
  • i3
  • powerline (python38Packages.powerline)
  • python37Packages.i3ipc
  • python37Packages.powerline
  • python38Packages.i3ipc
make[1]: Entering directory '/private/tmp/nix-build-i3-4.18.3.drv-0/i3-4.18.3'
  CC       src/i3-assignments.o
  CC       src/i3-bindings.o
  CC       src/i3-click.o
  CC       src/i3-commands.o
In file included from src/commands.c:10:
In file included from ./../i3-4.18.3/include/all.h:43:
In file included from ./../i3-4.18.3/include/data.h:12:
./../i3-4.18.3/include/libi3.h:23:10: fatal error: 'cairo/cairo-xcb.h' file not found
#include <cairo/cairo-xcb.h>
         ^~~~~~~~~~~~~~~~~~~
In file included from src/bindings.c:9:
In file included from ./../i3-4.18.3/include/all.h:43:
In file included from ./../i3-4.18.3/include/data.h:12:
./../i3-4.18.3/include/libi3.h:23:10: fatal error: 'cairo/cairo-xcb.h' file not found
#include <cairo/cairo-xcb.h>
         ^~~~~~~~~~~~~~~~~~~
1 error generated.
In file included from src/assignments.c:10:
In file included from ./../i3-4.18.3/include/all.h:43:
In file included from ./../i3-4.18.3/include/data.h:12:
./../i3-4.18.3/include/libi3.h:23:10: fatal error: 'cairo/cairo-xcb.h' file not found
#include <cairo/cairo-xcb.h>
         ^~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [Makefile:2209: src/i3-bindings.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:2195: src/i3-assignments.o] Error 1
In file included from src/click.c:10:
In file included from ./../i3-4.18.3/include/all.h:43:
In file included from ./../i3-4.18.3/include/data.h:12:
./../i3-4.18.3/include/libi3.h:23:10: fatal error: 'cairo/cairo-xcb.h' file not found
#include <cairo/cairo-xcb.h>
         ^~~~~~~~~~~~~~~~~~~
1 error generated.
1 error generated.
make[1]: *** [Makefile:2237: src/i3-commands.o] Error 1
make[1]: *** [Makefile:2223: src/i3-click.o] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-i3-4.18.3.drv-0/i3-4.18.3'
make: *** [Makefile:1334: all] Error 2

@wentasah
Copy link
Contributor Author

wentasah commented Nov 4, 2020

That's weird. The only functional change between i3-4.18.2 and i3-4.18.3 is this single commit, which not related to cairo. i3 depends on pango and pango has cairo in its propagatedBuildInputs.

If I run echo $NIX_CFLAGS_COMPILE|tr ' ' '\n'|grep cairo in my nixpkgs-review/pr-102615 shell, I get:

/nix/store/fn6sjqf47cgalkxgp7dmqi5grp9ifqdm-cairo-1.16.0-dev/include
/nix/store/2i8qx6qrl96yq5k5yfb5w24nz7c7f5mf-python3.8-pycairo-1.18.2/include
/nix/store/ij5rnq40r5b7x0f2b8mahg0rrqlx09ir-python3.7-pycairo-1.18.2/include
/nix/store/fn6sjqf47cgalkxgp7dmqi5grp9ifqdm-cairo-1.16.0-dev/include
/nix/store/2i8qx6qrl96yq5k5yfb5w24nz7c7f5mf-python3.8-pycairo-1.18.2/include

I guess that on Darwin, the cairo lines would be missing. Is it the case?

@SuperSandro2000
Copy link
Member

I guess that on Darwin, the cairo lines would be missing. Is it the case?

echo $NIX_CFLAGS_COMPILE|tr ' ' '\n'
-isystem
/nix/store/acbsjshd9mpq3hn9i1mj1l03jmc41828-libc++-7.1.0/include
-isystem
/nix/store/84507pkw9i7j3hc2dnc6nrzf10szmbzr-libc++abi-7.1.0/include
-isystem
/nix/store/r4np6gv2xaxr09l0mlviwq2sk1jadl8r-compiler-rt-7.1.0-dev/include
-iframework
/nix/store/4yfhzgb68xj7157b9qxxl8gr3v5q5nax-swift-corefoundation/Library/Frameworks
-isystem
/nix/store/acbsjshd9mpq3hn9i1mj1l03jmc41828-libc++-7.1.0/include
-isystem
/nix/store/84507pkw9i7j3hc2dnc6nrzf10szmbzr-libc++abi-7.1.0/include
-isystem
/nix/store/r4np6gv2xaxr09l0mlviwq2sk1jadl8r-compiler-rt-7.1.0-dev/include
-iframework
/nix/store/4yfhzgb68xj7157b9qxxl8gr3v5q5nax-swift-corefoundation/Library/Frameworks

Yes. If I add the grep back I get no output.

@wentasah wentasah deleted the i3-upgrade branch November 5, 2020 09:08
@wentasah
Copy link
Contributor Author

wentasah commented Nov 5, 2020

I'm affraid, I cannot help here. I'm not familiar with how nix works on Darwin and I doubt that the problem is caused by this PR. I believe, the same must happen even with i3 4.18.2. You can verify it by reverting the commit:

  1. git revert e90cfc7
  2. nix-review rev HEAD

@SuperSandro2000
Copy link
Member

Can we just mark i3 broken on darwin to reduce random build failures in future PRs?

@wentasah
Copy link
Contributor Author

wentasah commented Nov 6, 2020

Feel free to send a PR or file an issue. I'm quite new to Nix ecosystem and don't feel qualified for doing it myself. But as I mentioned above, I don't think that it's i3, what's broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[20.09] Network manager applet crashes on login
3 participants
@wentasah @SuperSandro2000 @teto