Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-providers.*: update #102618

Merged
merged 8 commits into from Nov 3, 2020
Merged

terraform-providers.*: update #102618

merged 8 commits into from Nov 3, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 3, 2020

Motivation for this change

This bumps some terraform providers. I had to move the hcloud provider into a separate derivation, as it removed the vendor folder, and vendorSha256 needs to be set (like others).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from risicle and kalbasit November 3, 2020 12:33
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102618 run on x86_64-linux 1

12 packages built:
  • terraform-full
  • terraform-providers.archive
  • terraform-providers.external
  • terraform-providers.hcloud
  • terraform-providers.local
  • terraform-providers.null
  • terraform-providers.random
  • terraform-providers.template
  • terraform-providers.tls
  • terraform_0_11-full
  • terraform_plugins_test
  • terragrunt

@flokli flokli merged commit cc496fd into NixOS:master Nov 3, 2020
@flokli flokli deleted the terraform-providers branch November 3, 2020 19:41
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102618 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • terragrunt
8 packages built:
  • terraform-providers.archive
  • terraform-providers.external
  • terraform-providers.hcloud
  • terraform-providers.local
  • terraform-providers.null
  • terraform-providers.random
  • terraform-providers.template
  • terraform-providers.tls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@risicle risicle Awaiting requested review from risicle

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @SuperSandro2000 @arianvp