[css-grid] Fix up that the width of nested grid container with margin:auto is zero #26376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 3, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2503910
branch
2 times, most recently
from
201cba3
to
7b6c1f2
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2503910
branch
9 times, most recently
from
f040227
to
fa981df
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2503910
branch
5 times, most recently
from
8bd2c33
to
6e8f1ef
Compare
…:auto is zero the width of nested grid container with margin:auto is zero when their item has 'max-height'. so the grid item's position is incorrect because the value of auto-margin computed with 'width' is wrong. Because intrin- sic width is not updated so they use the old intrinsic width. This patch is checking the dirty of the intrinsic logical width when the grid area is changed in |UpdateGridAreaLogicalSize|. Bug: 1149143 Change-Id: I4d4bf839723f05c60ed91b80148caf7b504d5aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503910 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#830086}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2503910
branch
from
6e8f1ef
to
7056bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the width of nested grid container with margin:auto is zero when their
item has 'max-height'. so the grid item's position is incorrect because
the value of auto-margin computed with 'width' is wrong. Because intrin-
sic width is not updated so they use the old intrinsic width.
This patch is checking the dirty of the intrinsic logical width when
the grid area is changed in |UpdateGridAreaLogicalSize|.
Bug: 1149143
Change-Id: I4d4bf839723f05c60ed91b80148caf7b504d5aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503910
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#830086}