Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ROCm to 3.9.0 #102602

Merged
merged 9 commits into from Nov 5, 2020
Merged

Update ROCm to 3.9.0 #102602

merged 9 commits into from Nov 5, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 3, 2020 •
edited

Motivation for this change

Updates the ROCm OpenCL stack

  • rocm-thunk: 3.8.0 -> 3.9.0
  • llvmPackages_rocm: 3.8.0 -> 3.9.0
  • rocm-device-libs: 3.8.0 -> 3.9.0
  • rocm-runtime: 3.8.0 -> 3.9.0
  • rocm-comgr: 3.8.0 -> 3.9.0
  • rocm-cmake: 3.8.0 -> 3.9.0
  • rocclr: 3.8.0 -> 3.9.0
  • rocm-opencl-runtime: 3.8.0 -> 3.9.0
  • rocm-smi: 3.8.0 -> 3.9.0

cc: @acowley @Flakebi

My RX580 is still on the shelf, so would appreciate a test on real hardware.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Flakebi
Flakebi approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! nixpkgs-review runs though fine and the OpenCL samples started working for me again

@acowley
Copy link
Contributor

acowley commented Nov 3, 2020

I haven't yet had a chance to test, but I'm curious if we will feel some of the issues with the 3.9 release, such as these changes to rocm-smi.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 4, 2020

I haven't yet had a chance to test, but I'm curious if we will feel some of the issues with the 3.9 release, such as these changes to rocm-smi.

Thanks for pointing to this issue. Let me know if it works. If not, I will remove the update of rocm-smi from this PR.

@acowley
Copy link
Contributor

acowley commented Nov 5, 2020

Good to go!

The patch applied cleanly to the overlay, but hip took a bit of work to update. I'm not seeing any issues yet with rocm-smi, but I will report back if anything comes up.

@danieldk
Copy link
Contributor Author

danieldk commented Nov 5, 2020

Thanks @Flakebi and @acowley for the reviews!

@danieldk danieldk merged commit 341aa3d into NixOS:master Nov 5, 2020
@danieldk danieldk deleted the rocm-3.9.0 branch November 5, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @acowley @Flakebi