Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: various versions updated by script #102600

Closed
wants to merge 1 commit into from
Closed

idea: various versions updated by script #102600

wants to merge 1 commit into from

Conversation

ktor
Copy link
Member

@ktor ktor commented Nov 3, 2020

Motivation for this change

New jetbrains versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ktor ktor requested a review from edwtjo as a code owner November 3, 2020 08:05
@SuperSandro2000
Copy link
Member

I did a quick check and most of those are already on master. If I missed one please update the PR and ping me.

@ktor
Copy link
Member Author

ktor commented Nov 25, 2020

Hi @SuperSandro2000 , thank you for checking! I was not aware that github has a problem updating "Files changed" tab. I have found that issue: isaacs/github#750

@SuperSandro2000
Copy link
Member

I noticed this happens a lot when reviewing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktor @SuperSandro2000