Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtools: 4.0.24 -> 4.0.25 #102606

Merged
merged 1 commit into from Nov 4, 2020
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 3, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mtools/versions.

meta.description for mtools is: "Utilities to access MS-DOS disks"

meta.homepage for mtools is: "https://www.gnu.org/software/mtools/"

meta.changelog for mtools is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
29 total rebuild path(s)

9 package rebuild(s)

9 x86_64-linux rebuild(s)
9 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
fwup
gnome3.gnome-boxes
ipxe
memtest86-efi
mtools
multibootusb
syslinux
unetbootin
wimlib
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/15f4axv508d411ahwn0kg3wq6vln9hhm-mtools-4.0.25 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A mtools https://github.com/r-ryantm/nixpkgs/archive/9937a7b946518f1cf4348a05f0a20adb2efa1e29.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/15f4axv508d411ahwn0kg3wq6vln9hhm-mtools-4.0.25
ls -la /nix/store/15f4axv508d411ahwn0kg3wq6vln9hhm-mtools-4.0.25/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

9 packages built:
  • fwup
  • gnome3.gnome-boxes
  • ipxe
  • memtest86-efi
  • mtools
  • multibootusb
  • syslinux
  • unetbootin
  • wimlib

Maintainer pings

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102606 1

9 packages built:
  • fwup
  • gnome3.gnome-boxes
  • ipxe
  • memtest86-efi
  • mtools
  • multibootusb
  • syslinux
  • unetbootin
  • wimlib

@jonringer jonringer merged commit bd5c059 into NixOS:master Nov 4, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 6, 2020

Result of nixpkgs-review pr 102606 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • multibootusb
  • wimlib
2 packages failed to build:
  • fwup
  • mtools
54 warnings generated.
clang  -DHAVE_CONFIG_H -DSYSCONFDIR=\"/nix/store/ywmrlj2kj94w18qmc2801cgdmxqm1p02-mtools-4.0.25/etc\" -DCPU_x86_64 -DVENDOR_apple -DOS_darwin19_6_0 -DOS_darwin19 -DOS_darwin -g -O2 -Wall -fno-strict-aliasing -I.  -I.  -c config.c
config.c:182:8: error: unknown type name 'locale_t'
static locale_t C=NULL;
       ^
config.c:186:6: warning: implicit declaration of function 'newlocale' is invalid in C99 [-Wimplicit-function-declaration]
        C = newlocale(LC_CTYPE_MASK, "C", NULL);
            ^
config.c:186:16: error: use of undeclared identifier 'LC_CTYPE_MASK'
        C = newlocale(LC_CTYPE_MASK, "C", NULL);
                      ^
config.c:193:15: warning: implicit declaration of function 'toupper_l' is invalid in C99 [-Wimplicit-function-declaration]
    int ret = toupper_l(drive, C);
              ^
config.c:205:12: warning: implicit declaration of function 'strncasecmp_l' is invalid in C99 [-Wimplicit-function-declaration]
    return strncasecmp_l(a, b, len, C);
           ^
3 warnings and 2 errors generated.
make: *** [Makefile:156: config.o] Error 1

@r-ryantm r-ryantm deleted the auto-update/mtools branch November 10, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants